WordPress.org

Make WordPress Core

Changes between Version 1 and Version 2 of Ticket #34359, comment 20


Ignore:
Timestamp:
11/21/2015 10:54:38 PM (3 years ago)
Author:
azaozz
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #34359, comment 20

    v1 v2  
    33It adds the cache to the default "bucket" which is keyed by blog ID. The same happens in the persistent cache as far as I know.
    44
    5 This function is actually (a bit) safer than `_wp_upload_dir_baseurl()` as the filter is run every time on the pre-cached data. I know it sounds weird to store some image sub-sizes in one location and other in another location, but there might be plugins doing that and depending on the `upload_dir` filter to select the proper path/URL. Even thinking it is better to commit this patch and remove _wp_upload_dir_baseurl() completely.
     5This function is actually (a bit) safer than `_wp_upload_dir_baseurl()` as the filter is run every time on the pre-cached data. I know it sounds weird to store some image sub-sizes in one location and other in another location, but there might be plugins doing that and depending on the `upload_dir` filter to select the proper path/URL.
     6
     7Thinking it is better to commit this patch and remove _wp_upload_dir_baseurl() completely. Can add a simple way to disable the caching for eventual edge cases on multisite installs.