Make WordPress Core

Opened 5 years ago

Closed 5 years ago

Last modified 5 years ago

#34363 closed defect (bug) (fixed)

Incorrect comment in wp_list_categories()

Reported by: SergeyBiryukov Owned by: boonebgorges
Milestone: 4.4 Priority: normal
Severity: normal Version: 4.3
Component: Taxonomy Keywords: good-first-bug has-patch
Focuses: Cc:


The comment for getting the posts page URL in wp_list_categories() is incorrect:

// Fallback for the 'All' link is the front page.

If should be "posts page", not "front page".

Introduced in [32292].

Attachments (1)

34363.patch (567 bytes) - added by sudar 5 years ago.

Download all attachments as: .zip

Change History (4)

5 years ago

#1 @sudar
5 years ago

  • Keywords has-patch added; needs-patch removed

Added patch to correct the comment.

#2 @boonebgorges
5 years ago

  • Owner set to boonebgorges
  • Resolution set to fixed
  • Status changed from new to closed

In 35291:

Correct inline comment in wp_list_categories().

The fallback link for the 'All' option is 'page_for_posts', not
'page_on_front'. Introduced in [32292].

Props sudar, SergeyBiryukov.
Fixes #34363.

#3 @SergeyBiryukov
5 years ago

In 35293:

In wp_list_categories(), rewrite a long condition for clarity.

See #34363.

Note: See TracTickets for help on using tickets.