WP_Site_Icon->get_post_metadata performance improvement

[ap.koponen]

Hi,

while trying to improve the performance of a plugin that used a lot of get_post_meta (WooCommerce Bookings) I noticed from my Cache Grind analysis that WP_Site_Icon->get_post_metadata was calling get_option a lot (11 336 times in my case).

I noticed that this call was unnecessary, if $single and $meta_key did not match so I refactored the function to call get_option only if it was necessary. This refactoring reduced the get_option calls to 0.

Ari-Pekka Koponen

[ap.koponen]

Diff for the refactored code.

[ocean90]

Nice catch!

[swissspidy]

34368.diff​ uses strict comparison and fixes the line indentation.

[ocean90]

Replying to swissspidy:

34368.diff​ uses strict comparison

Be careful with strict comparison:

<?php
var_dump( get_option( 'site_icon' ) ); // string(4) "1785"

[swissspidy]

Replying to ocean90:

Replying to swissspidy:

34368.diff​ uses strict comparison

Be careful with strict comparison:

<?php
var_dump( get_option( 'site_icon' ) ); // string(4) "1785"

That wasn't a problem in the unit test (see 34368.2.diff​), but I added an (int) nonetheless.

[ocean90]

Replying to swissspidy:

That wasn't a problem in the unit test (see 34368.2.diff​),

Right, because _insert_attachment()/wp_insert_attachment() returns an integer. But if it gets saved through the Customizer then the value is currently a string.

[obenland]

In 35299:

Site Icon: Get site icon ID only when needed.

Cuts down on unnecessary queries, especially in environments that rely on
post meta a lot. Reverts [32997].

Props ap.koponen, swissspidy.
Fixes #34368.