unit tests for the current_time() in functions.php

[pbearne]

just some unit tests

[pbearne]

Unit tests

[talldanwp]

Hi @pbearne, thanks so much for working on this! Tests are always welcome.

I applied the patch and ran the tests, and it looks like there's one failing test:

1) Tests_Functions_current_time::test_current_time_pass_random_String
Random_String passed
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-'Ram116202001_th31Thu, 16 Jan 2020 05:53:23 +00005315_pam2323UTC16'
+'Ram116202001_th31Thu, 16 Jan 2020 05:53:23 +00005315_pam2323+00:0016'

This would need to be addressed. A couple of other points looking at code consistency:

• Most other test filenames are camelCased instead of kebab-cased.
• The documentation at the top of the file seems to be the docs for the function. I don't think this is needed.

[pbearne]

Its been a while since I wrote this and TIME/DATE got fixed so I will revisit ASAP and get a new patch with the cleaned code

[pbearne]

updated file

[pbearne]

Patch cleaned up
I removed the broken test as it is not needed

[SergeyBiryukov]

Thanks for the patch!

Just noting that some tests for current_time() were previously added in [43594].

34378.diff​ cleans up some duplicate tests and brings the rest in line with the existing ones, including using delta comparison to avoid race conditions like #38381, #38815, #45821, #48145.

These still seem a bit redundant, as some of these cases are covered by the existing tests and there should be no functional difference between gmt_offset and timezone_string modes, per comment:9:ticket:48384.

That said, I guess it's a good idea to have some tests for gmt_offset too. Thanks again!

[SergeyBiryukov]

In 47081:

Date/Time: Add some basic tests for current_time().

Props pbearne, talldanwp, SergeyBiryukov.
Fixes #34378.