Internationalization by mistake

[nbachiyski]

In [4545] there are some strings that shouldn't have been i18ned:

$url  = sprintf(__('%1$s/%2$s%3$sm%4$s%5$s%6$sw%7$s%8$d'), get_settings('home'), '', '?', '=', $arc_year, '&', '=', $arcresult->week); 

and

date = sprintf(__('%1$d-%2$02d-%3$02d 00:00:00'), $arcresult->year, $arcresult->month, $arcresult->dayofmonth); 
$text = mysql2date($archive_day_date_format, $date); 

[Viper007Bond]

Uh, why shouldn't they be? You don't want to be able to change the arrangement of the output for different languages?

[markjaquith]

Think European style dates vs. American style dates vs. International style dates. For that, you need to be able to control the order of the elements.

[yskins]

I think nbachiyski is right.

$url  = sprintf(__('%1$s/%2$s%3$sm%4$s%5$s%6$sw%7$s%8$d'), get_settings('home'), '', '?', '=', $arc_year, '&', '=', $arcresult->week); 

The url will like "​http://example.com/?m=2006&w=52".

$date = sprintf(__('%1$d-%2$02d-%3$02d 00:00:00'), $arcresult->year, $arcresult->month, $arcresult->dayofmonth); 
$text = mysql2date($archive_day_date_format, $date); 

$date will like "2006-12-01 00:00:00". $date must use mysql style date formatting because it will be used in mysql2date function.

These two strings shouldn't be i18ned.

Uh, the strings which should be i18ned are:

// options for daily archive (only if you over-ride the general date format)
$archive_day_date_format = 'Y/m/d';

// options for weekly archive (only if you over-ride the general date format)
$archive_week_start_date_format = 'Y/m/d';
$archive_week_end_date_format	= 'Y/m/d';

[markjaquith]

Ooh, I see what you mean. Ryan, you put in [4545], so your call on the revert.

[ryan]

Sure, revert those bits. I was a bit too thorough. :-)

[markjaquith]

(In [4636]) Revert overzealous i18n from [4545]. Props nbachiyski. fixes #3438