WordPress.org

Make WordPress Core

Opened 4 years ago

Closed 4 years ago

Last modified 4 years ago

#34411 closed defect (bug) (fixed)

Make get_site_icon_url() filterable

Reported by: swissspidy Owned by: swissspidy
Milestone: 4.4 Priority: normal
Severity: normal Version: 4.3
Component: Media Keywords: good-first-bug has-patch
Focuses: Cc:
PR Number:

Description

[34903] introduces the new embeds feature, which displays the site icon in the bottom of the embed template.

In that template there's an embed_site_icon_url hook to allow filtering the site icon URL. It probably makes more sense to have a general site_icon_url filter in the get_site_icon_url().

See #32522

Attachments (1)

34411.diff (2.4 KB) - added by swissspidy 4 years ago.

Download all attachments as: .zip

Change History (4)

@swissspidy
4 years ago

#1 @swissspidy
4 years ago

  • Keywords has-patch added; needs-patch removed
  • Owner set to swissspidy
  • Status changed from new to assigned

34411.diff removes the two filters in the embed template with 1 filter in get_site_icon_url().

Note that the docs for embed_site_icon_url were wrongly declared twice anyway.

#2 @SergeyBiryukov
4 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 35379:

Site Icon: Introduce get_site_icon_url filter for the icon URL.

Remove oembed_site_icon_url filter added in [34903].

Props swissspidy.
Fixes #34411.

#3 @johnbillion
4 years ago

  • Version changed from trunk to 4.3
Note: See TracTickets for help on using tickets.