WordPress.org

Make WordPress Core

Opened 9 years ago

Closed 8 years ago

Last modified 6 years ago

#3442 closed defect (bug) (fixed)

role names shouldn't be gettexted in schema.php

Reported by: tenpura Owned by: ryan
Milestone: 2.5 Priority: normal
Severity: normal Version: 2.5
Component: Administration Keywords: i18n needs-patch
Focuses: Cc:

Description

Description:
Currently role names are stored into database in localized character encodings. If somehow those get garbled, unserialize() will fail to retrieve the data (because of the string length mismatch) and then a login failure occurs.

Suggested Solution:
Instead of using __() for the storing data in upgrade-schema.php, use __() when we display the data. (atleast for the role names, it seems to be a common problem.)

References:
http://www.google.com/search?hl=en&q=%22capabilities.php+on+line+19%22

Attachments (1)

translate_roles.diff (4.4 KB) - added by ryan 8 years ago.

Download all attachments as: .zip

Change History (14)

comment:1 @markjaquith9 years ago

  • Milestone set to 2.2

Sounds like a good solution, although it wouldn't fix blogs that are already broken.

Issues:

We'd need to change the role names on upgrade, and thanks to our muddled roles/capabilities system, that's not a simple SQL query... it'd have to be done in PHP.

Blogs sharing centralized user/role tables would have to be upgraded in unison (they probably would be anyway).

Maybe we can get the role/cap system changed in 2.2 to something simpler so we don't have to keep limping along with the one we have.

comment:2 @foolswisdom8 years ago

  • Milestone changed from 2.2 to 2.4

comment:3 @thee178 years ago

  • Resolution set to invalid
  • Status changed from new to closed

comment:4 @Nazgul8 years ago

  • Milestone 2.5 deleted

comment:5 @tenpura8 years ago

  • Milestone set to 2.5
  • Resolution invalid deleted
  • Status changed from closed to reopened
  • Summary changed from Garbled role names cause login failure to role names shouldn't be gettexted in schema.php
  • Version changed from 2.0.5 to 2.5

The description is a bit old but this is still a ongoing problem, so please don't close.

I said "garbled" but this actually could be anything (e.g. database encoding conversion) that causes string length mismatch of serialized data.

comment:6 @tenpura8 years ago

  • Keywords i18n added

comment:7 @ryan8 years ago

  • Owner changed from anonymous to ryan
  • Status changed from reopened to new

@ryan8 years ago

comment:8 @ryan8 years ago

Patch saves the untranslated strings to the roles array stored in the DB and translates them on the fly later. Dummy _c() calls are made to get the strings in the message catalog. translate_with_context() is used for on-the-fly translation since strings are not extracted from it when creating the message catalog.

comment:9 @nbachiyski8 years ago

Very nice! It preserves backward compatibility and the common roles' translation will change with locale change.

There is a samll problem: artificially added roles will be left as-is (good thing), except for stripping the text after the last |. Probably we should document having | in role names?

comment:10 @ryan8 years ago

Yes, let's document. Plugins that deal with roles will need to account for the context .

comment:11 @tenpura8 years ago

It's cool that we can change roles' translation anytime we want. Thank you!

BTW, I get Warning: Missing argument 2 for translate_with_context().

function translate_with_context($text, $domain) {

should be like

function translate_with_context($text, $domain = 'default') {

?

comment:12 @ryan8 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [6916]) Don't save translated role names to the DB. Instead, translate them on the fly. fixes #3442 #5537

comment:13 @ryan8 years ago

I defaulted the domain args to avoid the missing arg warnings.

Note: See TracTickets for help on using tickets.