WordPress.org
Get WordPress

Make WordPress Core

Opened 11 years ago

Closed 11 years ago

#34443 closed defect (bug) (fixed)

Correct type for global variable docs in add_submenu_page()

Reported by: NExt-Season Owned by: DrewAPicture
Priority: normal Milestone: 4.4
Component: Plugins Version: 4.4
Severity: normal Keywords: has-patch
Cc: Focuses: docs, administration

Description (last modified by swissspidy)

Fix global vars type in wp-admin/includes/plugin.php

Attachments (2)

plugin.diff​ (477 bytes ) - added by NExt-Season 11 years ago.
plugin.2.diff​ (746 bytes ) - added by NExt-Season 11 years ago.
ReFix

Download all attachments as: .zip

Change History (7)

@NExt-Season
11 years ago

#1 @swissspidy
11 years ago

  • Description modified (diff)
  • Keywords has-patch added
  • Summary Fix global vals type : wp-admin/includes/plugin.php → Correct type for global variable docs in add_submenu_page()
  • Type enhancement → defect (bug)

Hey there, thanks for the patch!

It would be great to have descriptions for those globals as well, if possible.

Note: get_admin_page_parent() defines $_wp_real_parent_file as a string, even though it's an array. Should be fixed too I guess.

#2 @SergeyBiryukov
11 years ago

  • Component General → Plugins
  • Focuses administration added
  • Keywords needs-patch added; has-patch removed

#3 @NExt-Season
11 years ago

Re fix it "get_admin_page_parent() defines $_wp_real_parent_file"

@NExt-Season
11 years ago

ReFix

#4 @DrewAPicture
11 years ago

  • Keywords has-patch added; needs-patch removed
  • Milestone Awaiting Review → 4.4

@NExt-Season Thanks for the patch :-)

#5 @DrewAPicture
11 years ago

  • Owner set to DrewAPicture
  • Resolution → fixed
  • Status new → closed

In 35495:

Docs: Fix two notations for the $_wp_real_parent_file global, which is an array.

Props NExt-Season.
Fixes #34443.

Note: See TracTickets for help on using tickets.