Remove CPT if exists menu item

[sebastian.pisula]

I add to menu Post Type Archive URL and i remove function register_post_type(). And i have notice:

Notice: Trying to get property of non-object in D:\xampp\htdocs\wordpress\wp-admin\includes\class-walker-nav-menu-edit.php on line 83

Error is in line $original_title = $original_object->labels->archives; because post object not exists

[sebastian.pisula]

I found error during save menu if CPT object not exists:

Notice: Trying to get property of non-object in wp-includes\nav-menu.php on line 408

[sebastian.pisula]

Error still exists. I have plugin where I register post type. In menu add item "Post Type Archive". When I turn off my plugin in menu manager I have notice:

Notice: Trying to get property of non-object in /wp-admin/includes/class-walker-nav-menu-edit.php on line 83

Notice: Trying to get property of non-object in /wp-admin/includes/class-walker-nav-menu-edit.php on line 83

In attachment is screen of bug. My patch fixes this.

[sebastian.pisula]

screen with error in menu

[swissspidy]

Apart from the assignment in the condition the patch makes sense to me. Will test.

Related: #13958

[kucrut]

Refresh patch

[jorbin]

@swisspiddy thanks for looking into this. Please update with anything you find.

[swissspidy]

The latest patch works great. No notices are shown.

[dd32]

In general PHP Notices are not normally something that goes into a point release, as you shouldn't be running with display_errors enabled on a production site. Notices are not displayed by default.

[dd32]

In 36095:

Nav Menus: Avoid a PHP Notice when a menu contains a now unregistered post type archive.

Props kucrut.
Fixes #34449 for trunk.

[dd32]

re-opening for 4.4.1 consideration, based on the above, does anyone feel that it's a common scenario for a user to run into?

Especially considering PHP notices should require WP_DEBUG to be on and display_errors to be enabled in production.