Wrong default order for pages list table in 4.4

[szaqal21]

Default order of pages list table in 4.4 is "date". I've investigated source and found that this is caused by function wp_edit_posts_query():

if ( isset( $q['orderby'] ) ) {
		$orderby = $q['orderby'];
	} elseif ( isset( $q['post_status'] ) && in_array( $q['post_status'], array( 'pending', 'draft' ) ) ) {
		$orderby = 'modified';
	} else {
		$orderby = 'date';
	}
}

else statement is causing this problem:

else {
	$orderby = 'date';
}

it wasn't present in 4.3.

[SergeyBiryukov]

Introduced in [34728].

[ellie.roepken]

Check that the post type is hierarchical before assuming posts should be listed by date.

[SergeyBiryukov]

There's a block for hierarchical post types in line 1048​, which never runs after [34728], because $orderby is always set now.

34473-wrong-default-order-for-pages.diff​ looks good. No need to check if $post_type is set though, it's set above.

[SergeyBiryukov]

In 35482:

Post List Table: Hierarchical post types should not default to sorting by date.

Regression introduced in [34728].

Props ellie.roepken.
Fixes #34473. See #25493.