oEmbed "Read more" accessibility

[GaryJ]

See ​https://make.wordpress.org/core/2015/10/28/new-embeds-feature-in-wordpress-4-4/embed/ as a demo page.

The "Read more" link at the end has no screen reader text for the post title, so if multiple WP-based embeds are added to a webpage (regardless of whether that site runs WP or not), there will be multiple links to different URLs, all with the same link text.

It would be good if this could be fixed in Core before 4.4 is released.

[swissspidy]

Thanks for the ticket!

34481.diff​ solves this the same way some of the default themes do it (Twenty Fourteen, Twenty Thirteen, to name two). The only difference is the displayed text ("Read more" vs. "Continue reading").

[SergeyBiryukov]

"Continue reading {post name}" sounds more natural to me than "Read more {post name}".

Should we consider changing the label to "Continue reading"?

[GaryJ]

Replying to SergeyBiryukov:

"Continue reading {post name}" sounds more natural to me than "Read more {post name}".

Should we consider changing the label to "Continue reading"?

I was just thinking the same. Was trying to see if the core themes had an "about" in there, as in "Read more about Foo".

+1 to "Continue reading {post name}".

[swissspidy]

Screenshot of 34481.2.diff

[swissspidy]

34481.2.diff​ changes the text to "Continue reading (post name)" and updates the docblock as well.

[GaryJ]

Looks good @swissspidy. I'd suggest keeping the original DocBlock Summary, and having your new blurb as the Description. The summary outlines the what, the description dives into the how.

/**
 * Filters the string in the "more" link displayed after a trimmed excerpt.
 *
 * Replaces "[...]" (appended to automatically generated excerpts) with an
 * ellipsis and a Continue reading link in the embed template. 
 * 
 * @since 4.4.0
...
*/

[swissspidy]

Adds description to wp_embed_excerpt_more() docblock

[SergeyBiryukov]

In 35432:

Embeds: Include post name in "Continue reading" links to provide a readable link for screenreaders.

Props swissspidy.
Fixes #34481.