Make WordPress Core

Opened 9 years ago

Closed 8 years ago

Last modified 8 years ago

#34485 closed enhancement (wontfix)

Site Icon feature should be usable to users with "edit_theme_options" cap

Reported by: chrisplaneta's profile chrisplaneta Owned by: obenland's profile obenland
Milestone: Priority: normal
Severity: normal Version: 4.3
Component: Customize Keywords:
Focuses: administration Cc:

Description

At the moment "site icon" feature in customizer is accessible only to administrators with "manage_options" capability which I believe is a mistake. Since "edit_theme_options" lets users see and use visual settings in the customizer they should also be able to modify "site icon".

In most cases I don't give my clients access to settings that can change how wordpress works but I want to let them tweak how the site looks. Site icon is one of those things and really shouldn't be accessible only to top administrators with manage options cap.

Change History (6)

#1 @chrisplaneta
9 years ago

  • Summary changed from Site Icon should be visible to users with "edit_theme_options" cap to Site Icon feature should be usable to users with "edit_theme_options" cap

#2 @westonruter
9 years ago

  • Milestone changed from Awaiting Review to 4.4
  • Owner set to obenland
  • Status changed from new to assigned
  • Version changed from 4.3.1 to 4.3

Feature introduced in #16434.

#3 @westonruter
9 years ago

  • Milestone changed from 4.4 to Awaiting Review

#4 @celloexpressions
8 years ago

  • Keywords close added

It's manage_options because the feature is global (an option), not theme-specific (theme_mod). If needed based on personal usage, the required capability can be changed via a plugin doing something like:

add_action( 'customize_register', function ( $wp_customize ) {
	$wp_customize->get_setting('site_icon')->capability = 'edit_theme_options';
}

I don't think we should change it in core, though.

#5 follow-up: @obenland
8 years ago

  • Keywords close removed
  • Milestone Awaiting Review deleted
  • Resolution set to wontfix
  • Status changed from assigned to closed

Hi @chrisplaneta, thanks for opening the ticket, I hope to see many more! :)

I agree with @celloexpressions in this instance, it's not a theme option we're talking about here, but a site setting similar to name and tagline. Does the example he gives above as to how you can enable it for your clients satisfy your use case?

Apologies for not getting back to you earlier, I must have missed the ticket getting assigned to me 6 months ago.

#6 in reply to: ↑ 5 @chrisplaneta
8 years ago

@obenland

From the technical standpoint it sounds right, but still, it doesn't feel right from the feature accessibility point of view.

@celloexpressions Thank you for the script :) it will sure come in handy

Note: See TracTickets for help on using tickets.