Changes between Initial Version and Version 3 of Ticket #34492

Timestamp:

10/29/2015 10:24:58 PM (5 years ago)

Author:

afercia

Comment:

@neoxx good catch, thanks very much :) Wondering what to do here, in some cases should be a <h3>:

Without the "tabs", should be a <h2>. We've discussed a bit the "tabs", probably they shouldn't be within a heading in the first place and they're more a navigation sub-menu. I'd be inclined to keep things simple and just change the heading output by do_settings_sections() in a <h2>. As a side note, this is one of the reasons why I'm not so happy when core outputs some HTML assuming it's the proper markup in any case, without giving users the ability to filter it some way :) Will ask the accessibility team for some feedback, the proposed patch looks the best option to me.