WordPress.org

Make WordPress Core

Changes between Initial Version and Version 3 of Ticket #34492


Ignore:
Timestamp:
10/29/2015 10:24:58 PM (4 years ago)
Author:
afercia
Comment:

@neoxx good catch, thanks very much :) Wondering what to do here, in some cases should be a <h3>:

https://cldup.com/32zicOgUD7.png

Without the "tabs", should be a <h2>. We've discussed a bit the "tabs", probably they shouldn't be within a heading in the first place and they're more a navigation sub-menu. I'd be inclined to keep things simple and just change the heading output by do_settings_sections() in a <h2>. As a side note, this is one of the reasons why I'm not so happy when core outputs some HTML assuming it's the proper markup in any case, without giving users the ability to filter it some way :) Will ask the accessibility team for some feedback, the proposed patch looks the best option to me.

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #34492

    • Property Status changed from new to assigned
    • Property Focuses ui added
    • Property Summary changed from Adapt title in Settings API to new hierarchy to #a11y-headings - Adapt title in Settings API to new hierarchy
    • Property Owner set to afercia
    • Property Milestone changed from Awaiting Review to 4.4
    • Property Keywords has-patch added
  • Ticket #34492 – Description

    initial v3  
    11Following https://make.wordpress.org/core/2015/10/28/headings-hierarchy-changes-in-the-admin-screens/ the title in ''do_settings_sections()'' should move up one level, too.
     2
     3#a11y-headings