Negative number for "No role"?

[pavelevap]

Is it possible? See attached screenshot.

[johnbillion]

Can you provide some more info please? A question does not make a good bug report.

It looks like you may have some malformed users in your users table.

[pavelevap]

Sorry, I had to go and did not have time to find additional details. There are 11 users, one of them (admin) has 2 roles (Administrator and Keymaster), all others only one (standard WP roles). Keymaster role is probably from bbPress, but this plugin is not active now. There is no user without role. Any ideas what should I check tomorrow?

[netweb]

I just tried various combinations of activating and deactivating bbPress to try and recreate a user without a role and could not.

[pavelevap]

So, I tried to debug it a little bit and problem is here: https://core.trac.wordpress.org/browser/trunk/src/wp-includes/user-functions.php#L779

$role_counts['none'] = ( $total_users - array_sum( $role_counts ) );

This logic does not work for me.

$role_counts:

array(5) { ["administrator"]=> int(1) ["editor"]=> int(1) ["author"]=> int(2) ["subscriber"]=> int(7) ["bbp_keymaster"]=> int(1) }

array_sum( $role_counts ): int(12)

$total_users: int(11)

Result is -1

bbPress plugin is deactivated, but was active before and Administrator is also Keymaster.

[johnbillion]

This is reproducible if you've a user on your site with a role that no longer exists (for example by using the Members plugin to add a role, assigning a user that role, then deactivating the Members plugin) and then subsequently activate a plugin such as bbPress which also adds a custom user role. I've not dug into the root cause yet.

[johnbillion]

cc @greenshady just FYI

[greenshady]

I believe this is the changeset where this issue was introduced: [34965]

[johnbillion]

In 35707:

Ensure the count for users with no role remains accurate when users with multiple roles are present.

See #34495

[johnbillion]

Turns out this was due to miscalculation of user counts when users with multiple roles are present. Fixed in [35707].