Make WordPress Core

Opened 10 years ago

Closed 10 years ago

Last modified 10 years ago

#34498 closed defect (bug) (fixed)

Avoid using <code> in translation string (wp-admin/includes/class-wp-plugins-list-table.php)

Reported by: ramiy's profile ramiy Owned by: sergeybiryukov's profile SergeyBiryukov
Milestone: 4.4 Priority: normal
Severity: normal Version:
Component: I18N Keywords: has-patch
Focuses: Cc:

Description

The attached patch is fixing three translation strings.

Attachments (1)

34498.patch (2.1 KB) - added by ramiy 10 years ago.

Download all attachments as: .zip

Change History (8)

@ramiy
10 years ago

#1 @ramiy
10 years ago

  • Keywords has-patch added

#2 @SergeyBiryukov
10 years ago

  • Milestone changed from Awaiting Review to 4.4

#3 @SergeyBiryukov
10 years ago

  • Owner set to SergeyBiryukov
  • Resolution set to fixed
  • Status changed from new to closed

In 35440:

Don't use <code> in translatable strings in wp-admin/includes/class-wp-plugins-list-table.php.

Add translator commments.

Props ramiy.
Fixes #34498.

#4 @SergeyBiryukov
10 years ago

In 35441:

Add <code> tag missed in [35440].

See #34498.

#5 follow-up: @ramiy
10 years ago

@SergeyBiryukov, the last string still has <code> tags.

OLD STRING:
__( 'Requires <code>%s</code> in <code>wp-config.php</code>.' )

YOUR COMMIT:
__( 'Requires %s in <code>wp-config.php</code>.' )

MY PROPOSAL:
__( 'Requires %1$s in %2$s.' )

In many cases we had file names with code tags, and we moved them out of the translation strings. Removing the HTML tags from the string makes it easier to translate those strings, especially in RTL languages.

#6 in reply to: ↑ 5 @SergeyBiryukov
10 years ago

Replying to ramiy:

In many cases we had file names with code tags, and we moved them out of the translation strings.

Right, missed that while iterating on the patch.

#7 @SergeyBiryukov
10 years ago

In 35445:

Replace a second instance of <code> in translatable string left in [35440].

Props ramiy.
See #34498.

Note: See TracTickets for help on using tickets.