WordPress.org

Make WordPress Core

Opened 4 years ago

Closed 4 years ago

#34503 closed defect (bug) (fixed)

Avoid using HTML tags in translation strings (wp-includes/theme-compat/*.php)

Reported by: ramiy Owned by: SergeyBiryukov
Milestone: 4.4 Priority: normal
Severity: normal Version:
Component: I18N Keywords: has-patch
Focuses: Cc:

Description

Many strings fixes. Mainly avoiding the <a> HTML tags in translations strings.

Attachments (2)

34503.patch (3.8 KB) - added by ramiy 4 years ago.
34503.2.patch (7.5 KB) - added by ramiy 4 years ago.
fixing strings in all the theme-compat files

Download all attachments as: .zip

Change History (12)

@ramiy
4 years ago

#1 @ramiy
4 years ago

  • Keywords has-patch added

Also, if its possible, remove the word "blog" from the strings.

#2 @ramiy
4 years ago

  • Summary changed from Avoid using HTML tags in translation strings (wp-includes/theme-compat/sidebar.php) to Avoid using HTML tags in translation strings (wp-includes/theme-compat/*.php)

@ramiy
4 years ago

fixing strings in all the theme-compat files

#3 @ramiy
4 years ago

@SergeyBiryukov, use the second patch.

#4 @SergeyBiryukov
4 years ago

  • Milestone changed from Awaiting Review to 4.4

Looks good, the only thing I would keep is <strong>&#8216;%3$s&#8217;</strong>, because the quotes should be inside the <strong> tag too.

#5 @SergeyBiryukov
4 years ago

  • Owner set to SergeyBiryukov
  • Status changed from new to reviewing

#6 @SergeyBiryukov
4 years ago

In 35454:

Add translator comments for strings in theme-compat/comments-popup.php.

Props ramiy.
See #34503.

#7 @SergeyBiryukov
4 years ago

In 35455:

Don't use <a> in translatable string in theme-compat/comments.php.

Add translator comments.

Props ramiy.
See #34503.

#8 @SergeyBiryukov
4 years ago

In 35456:

Add translator comments for strings in theme-compat/footer.php.

Props ramiy.
See #34503.

#9 @SergeyBiryukov
4 years ago

In 35457:

Add translator comments for strings in theme-compat/header.php.

Props ramiy.
See #34503.

#10 @SergeyBiryukov
4 years ago

  • Resolution set to fixed
  • Status changed from reviewing to closed

In 35458:

Don't use <a> in translatable strings in theme-compat/sidebar.php.

Add translator comments.

Props ramiy.
Fixes #34503.

Note: See TracTickets for help on using tickets.