get_blogaddress_by_name() does not reflect scheme of the blog

[johnbillion]

get_blogaddress_by_name() suffers from the same problem that get_blogaddress_by_id() suffered from as reported in #14867 and fixed in [35446]. The scheme of the returned URL does not reflect that of the actual blog.

In addition, the scheme of the return URL gets polluted by the current request.

[jeremyfelt]

It seems like the only context this is used in is wp-signup.php as a way to display what a new site's address would be if it was created. In that case, using the scheme of network_home_url() may still make sense.

I could also see finding a way to deprecate get_blogaddress_by_name().

[flixos90]

This bug could be fixed with #35791 and #31405. We could make a WP_Site_Query to get the site and then use the original URL scheme to return the original scheme.

[thomaswm]

Replying to flixos90:

We could make a WP_Site_Query to get the site and then use the original URL scheme to return the original scheme.

As jeremyfelt said, the function is only used in wp-signup.php to display the text

'The site you were looking for, %s, does not exist, but you can create it now!'

As the site does not exist yet, its scheme cannot be determined by querying the database for its home URL or site URL. Therefore, this ticket might be a wontfix.