Opened 10 years ago
Last modified 6 weeks ago
#34507 new enhancement
New action `before_login_form`
Reported by: |
|
Owned by: | |
---|---|---|---|
Milestone: | Awaiting Review | Priority: | normal |
Severity: | normal | Version: | |
Component: | Login and Registration | Keywords: | has-patch |
Focuses: | Cc: |
Description
I can add new fields before default fields form. For example I can add social login :
Attachments (2)
Change History (10)
This ticket was mentioned in Slack in #core by sebastian.pisula. View the logs.
9 years ago
#3
follow-up:
↓ 4
@
9 years ago
- Keywords has-patch needs-refresh added
The patch would need some improved docblock description (see login_form
hook for example) and an updated @since
value. Also, should the hook name be login_form_before
?
In general, I think it's time to finally make the login form more modular and testable.
#4
in reply to:
↑ 3
;
follow-up:
↓ 7
@
9 years ago
Replying to swissspidy:
Also, should the hook name be
login_form_before
?
Given that it fires inside the form tag, I think login_form_top
would be a better name, see comment_form_top for example.
If login_form_before
was introduced, I'd expect it to fire before the form tag, see comment_form_before.
#7
in reply to:
↑ 4
@
6 weeks ago
- Keywords needs-patch added; has-patch needs-refresh needs-docs removed
Replying to SergeyBiryukov:
Given that it fires inside the form tag, I think
login_form_top
would be a better name, see comment_form_top for example.
If
login_form_before
was introduced, I'd expect it to fire before the form tag, see comment_form_before.
Completely agree with this. Updating the keywords to match that there is no patch that does this.
This ticket was mentioned in PR #8902 on WordPress/wordpress-develop by @sukhendu2002.
6 weeks ago
#8
- Keywords has-patch added; needs-patch removed
Trac ticket: https://core.trac.wordpress.org/ticket/34507
I renew ticket