Opened 11 years ago
Closed 11 years ago
#34515 closed defect (bug) (fixed)
Edit tags PHP notice and admin notice
| Reported by: | afercia | Owned by: | afercia |
|---|---|---|---|
| Priority: | normal | Milestone: | 4.5 |
| Component: | Administration | Version: | 4.4 |
| Severity: | normal | Keywords: | has-patch has-screenshots |
| Cc: | Focuses: | ui |
Description
In edit-tag-form.php there's an initial check for an empty $tag_ID, when there's no ID a PHP notice is displayed and an admin notice too.
The admin notice should probably have a red border since it's an error (currently it uses the CSS class updated) and probably shouldn't be dismissible since PHP returns and there's nothing else to display.
To reproduce, just don't pass the tag_ID value in the query string:
Attachments (3)
Change History (8)
Note:
See TracTickets
for help on using tickets.
![(please configure the [header_logo] section in trac.ini)](/chrome/site/your_project_logo.png)


Screenshots with the proposed patch applied: