Opened 10 years ago
Closed 10 years ago
#34515 closed defect (bug) (fixed)
Edit tags PHP notice and admin notice
| Reported by: |
|
Owned by: |
|
|---|---|---|---|
| Milestone: | 4.5 | Priority: | normal |
| Severity: | normal | Version: | 4.4 |
| Component: | Administration | Keywords: | has-patch has-screenshots |
| Focuses: | ui | Cc: |
Description
In edit-tag-form.php there's an initial check for an empty $tag_ID, when there's no ID a PHP notice is displayed and an admin notice too.
The admin notice should probably have a red border since it's an error (currently it uses the CSS class updated) and probably shouldn't be dismissible since PHP returns and there's nothing else to display.
To reproduce, just don't pass the tag_ID value in the query string:
Attachments (3)
Change History (8)
#2
@
10 years ago
- Milestone changed from Awaiting Review to 4.5
- Owner set to afercia
- Status changed from new to assigned
- Version changed from 4.3 to 4.4
Refreshed patch, trying to prevent a couple of potential PHP notices.
Note: See
TracTickets for help on using
tickets.


Screenshots with the proposed patch applied: