Make WordPress Core

Opened 11 years ago

Closed 11 years ago

#34522 closed defect (bug) (fixed)

Incorrect docblock for embed_defaults filter

Reported by: swissspidy Owned by: DrewAPicture
Priority: normal Milestone: 4.4
Component: Embeds Version: 2.9
Severity: trivial Keywords: good-first-bug has-patch
Cc: Focuses: docs

Description (last modified by swissspidy)

The embed_defaults filter passes width and height in an array (using compact), and the url as a second param. The docblock lists three params though.

It should be made clear that only two paerams are passed to the filter callback.

Attachments (1)

34522.diff​ (722 bytes ) - added by swissspidy 11 years ago.

Download all attachments as: .zip

Change History (4)

#1 @swissspidy
11 years ago

  • Description modified (diff)

@swissspidy
11 years ago

#2 @swissspidy
11 years ago

  • Keywords has-patch added; needs-patch removed
  • Milestone Awaiting Review → 4.4
  • Owner set to DrewAPicture
  • Severity normal → trivial
  • Status new → assigned
  • Version → 2.9

#3 @DrewAPicture
11 years ago

  • Resolution → fixed
  • Status assigned → closed

In 35485:

Docs: Correctly notate that the default $width and $height embed dimensions are passed to the embed_defaults filter as a compacted array, and not two distinct parameters.

Props swissspidy.
Fixes #34522.

Note: See TracTickets for help on using tickets.