Embeds: Make function parameters more clear

[swissspidy]

As raised ​in the comments on the dev post:

The first param ($post) of get_post_embed_html() and get_oembed_response_data() is optional, the others are required. We should change the order of the params.

Patch attached.

[swissspidy]

get_oembed_response_data() is called by the API endpoint controller and never in a context where it makes sense to use the global post object.

Therefore, 34523.2.diff​ only changes the param order for get_post_embed_html() and does correctly so by not forgetting the embed template.

[SergeyBiryukov]

In 35470:

Embeds: Fix typo in oembed_request_post_id filter DocBlock.

Props swissspidy.
See #34523.

[SergeyBiryukov]

In 35471:

Embeds: In get_oembed_response_data(), make the $post argument required.

get_oembed_response_data() is called by the API endpoint controller and never in a context where it makes sense to use the global post object.

Props swissspidy.
See #34523.

[SergeyBiryukov]

In 35472:

Embeds: In get_post_embed_html(), move the optional $post argument after the required $width and $height.

Props swissspidy.
Fixes #34523.