Context Navigation

← Previous Ticket
Next Ticket →

#34534 closed enhancement (fixed)

WP oEmbed: Filter entire logo markup to allow inline svg, objects, et al.

Reported by:	peterwilsoncc	Owned by:	swissspidy
Priority:	normal	Milestone:	4.4
Component:	Embeds	Version:
Severity:	normal	Keywords:	has-patch commit
Cc:		Focuses:	docs

Description

The logo markup in wp-includes/embed-template.php includes an image tag.

printf(
        '<a href="%s" target="_top"><img src="%s" srcset="%s 2x" width="32" height="32" alt="" class="wp-embed-site-icon"/><span>%s</span></a>',
        esc_url( home_url() ),
        esc_url( get_site_icon_url( 32, admin_url( 'images/w-logo-blue.png' ) ) ),
        esc_url( get_site_icon_url( 64, admin_url( 'images/w-logo-blue.png' ) ) ),
        esc_html( get_bloginfo( 'name' ) )
);

It'd be grand if the entire markup could be filterable to allow for inline-svg, objects, plain text and other markup for the logo.

Filter name suggestions:

embed_logo_markup
embed_site_title

Attachments (1)

34534.diff (1.7 KB ) - added by swissspidy 11 years ago.

Download all attachments as: .zip

Change History (7)

#1 @dd32
11 years ago

Milestone Awaiting Review → 4.4

Shifting for review by others

#2 @swissspidy
11 years ago

Sounds reasonable to me. While working on #34561 I've added an embed_site_title filter to the patch there.

#3 @wonderboymusic
11 years ago

Owner set to swissspidy
Status new → assigned

#4 @swissspidy
11 years ago

Status assigned → accepted

@swissspidy
11 years ago

Attachment 34534.diff added

#5 @swissspidy
11 years ago

Focuses docs added
Keywords has-patch commit added; needs-patch removed

#6 @pento
11 years ago

Resolution → fixed
Status accepted → closed

In 35578:

Embeds: Add a filter for the site title HTML.

Props swissspidy.

Fixes #34534.

Note: See TracTickets for help on using tickets.

Download in other formats:

Make WordPress Core

Context Navigation

#34534 closed enhancement (fixed)

WP oEmbed: Filter entire logo markup to allow inline svg, objects, et al.

Description

Attachments (1)

Change History (7)

#1 @dd32 11 years ago

#2 @swissspidy 11 years ago

#3 @wonderboymusic 11 years ago

#4 @swissspidy 11 years ago

@swissspidy 11 years ago

#5 @swissspidy 11 years ago

#6 @pento 11 years ago