WordPress.org

Make WordPress Core

Opened 5 years ago

Closed 5 years ago

#34540 closed defect (bug) (fixed)

Build tools: match compatibility settings for cssmin & autoprefixer

Reported by: peterwilsoncc Owned by: jorbin
Milestone: 4.4 Priority: normal
Severity: normal Version: 4.4
Component: Build/Test Tools Keywords: good-first-bug has-patch commit
Focuses: Cc:

Description (last modified by peterwilsoncc)

clean css (used by cssmin) now has an IE compatibility setting, it should match that of autoprefixer (ie7) in the build settings.

Refs:
https://github.com/jakubpawlowicz/clean-css/blob/master/README.md#how-to-set-a-compatibility-mode

https://github.com/gruntjs/grunt-contrib-cssmin/blob/master/README.md#options

Updated: November 12 to change IE version to IE7 per autoprefixer setting.

Attachments (1)

Gruntfile.diff (614 bytes) - added by christophherr 5 years ago.
Adds compatibility setting for Internet Explorer to the cssmin options. Matches the version in Autoprefier (>=7)

Download all attachments as: .zip

Change History (9)

#1 @netweb
5 years ago

  • Description modified (diff)
  • Milestone changed from Awaiting Review to 4.4

Related: #34177

@christophherr
5 years ago

Adds compatibility setting for Internet Explorer to the cssmin options. Matches the version in Autoprefier (>=7)

#2 @christophherr
5 years ago

  • Keywords has-patch added; needs-patch removed

#3 @wonderboymusic
5 years ago

  • Owner set to jorbin
  • Status changed from new to assigned

#4 @netweb
5 years ago

@peterwilsoncc Should the patch use ie8 rather than ie7?

#5 follow-up: @peterwilsoncc
5 years ago

Replying to netweb:

@peterwilsoncc Should the patch use ie8 rather than ie7?

IE7 as in Gruntfile.diff is correct to match autoprefixer's setting, I made an error in the original description.

#6 @peterwilsoncc
5 years ago

  • Description modified (diff)

#7 in reply to: ↑ 5 @netweb
5 years ago

  • Keywords commit added

Replying to peterwilsoncc:

Replying to netweb:

@peterwilsoncc Should the patch use ie8 rather than ie7?

IE7 as in Gruntfile.diff is correct to match autoprefixer's setting, I made an error in the original description.

Thanks

#8 @jorbin
5 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 35684:

Set cssmin compatibility to ie7

This matches the autoprefixer setting. This changes all compiled CSS.

Fixes #34540.
Props christophherr, peterwilsoncc, netweb

Note: See TracTickets for help on using tickets.