WordPress.org

Make WordPress Core

Opened 5 years ago

Closed 5 years ago

#34547 closed defect (bug) (fixed)

Improve the install page language chooser button style

Reported by: afercia Owned by: afercia
Milestone: 4.5 Priority: normal
Severity: normal Version: 4.3
Component: Upgrade/Install Keywords: has-patch has-screenshots
Focuses: ui Cc:

Description

The language chooser button has its own, unique, non-standard, size and the button text is not perfectly vertically centered, at least not in all browsers. See in the screenshot below, how it looks in latest Chrome on Windows (on the left) and with a better vertical alignment (on the right):

https://cldup.com/eVRYPbl0Ds.png

Attachments (1)

34547.patch (629 bytes) - added by afercia 5 years ago.

Download all attachments as: .zip

Change History (7)

@afercia
5 years ago

#1 follow-up: @afercia
5 years ago

  • Keywords has-patch has-screenshots added

The proposed patch sets a proper line-height for the button and also improves and simplifies the spinner position. Tested in latest Chrome on Windows, latest Firefox on Windows, IE 8. Would need to be checked in modern IEs and on Macs.

#2 @DrewAPicture
5 years ago

  • Summary changed from Improve the language chooser button style to Improve the install page language chooser button style

The language chooser is on four different screens now, specificity is helpful :)

#3 @samuelsidler
5 years ago

  • Milestone changed from Awaiting Review to Future Release

Seems like a good idea.

#4 @afercia
5 years ago

  • Milestone changed from Future Release to 4.5
  • Owner set to afercia
  • Status changed from new to assigned

#5 in reply to: ↑ 1 @afercia
5 years ago

Replying to afercia:

Would need to be checked in modern IEs and on Macs.

Just tested in Edge, looks good to me.

#6 @afercia
5 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 36423:

Install: Improve the install page language chooser button style.

Fixes #34547.

Note: See TracTickets for help on using tickets.