Opened 9 years ago
Closed 9 years ago
#34556 closed defect (bug) (fixed)
Visual issues with form fields in edit attachment modal
Reported by: |
|
Owned by: |
|
---|---|---|---|
Milestone: | 4.4 | Priority: | normal |
Severity: | normal | Version: | |
Component: | Media | Keywords: | has-patch has-screenshots |
Focuses: | ui, administration | Cc: |
Description
There is a minor issue with the form fields in the edit attachment modal - their box-sizing
is content-box
(as inherited from .media-modal *
), which makes them look awkward in some locations.
Steps to reproduce:
- Go to Media
- Click on an image attachment.
- In the popup, below the image, click on the "Edit Image" button.
- Take a look at all of the fields - they are larger than they should be (compared to the other media modals).
The issue can be observed best with the Apply changes to:
radio buttons, where the checked
circle is not in the middle, but a little off to the top & left.
As a solution we have to make sure that the box-sizing
of the edit attachment modal input, select, media
is border-box
instead of content-box
. This will fix the issue on both desktop and mobile devices.
Attachments (3)
Change History (9)
#2
@
9 years ago
+1. I think this one should be included in 4.4. The current radio buttons (and checkboxes - if any) look awkward.
#3
@
9 years ago
- Milestone changed from Awaiting Review to 4.4
- Owner set to obenland
- Status changed from new to accepted
- Version trunk deleted
#4
@
9 years ago
It looks like [29727] tried to fix that before. Not sure whether it broke again or if it was an oversight in the previous fix.
Fix the
box-sizing
of the input, textarea and select fields in the edit attachment frame.