WordPress.org

Make WordPress Core

Changes between Initial Version and Version 1 of Ticket #34560, comment 15


Ignore:
Timestamp:
11/04/2015 08:50:55 PM (4 years ago)
Author:
pdfernhout
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #34560, comment 15

    initial v1  
    22> Thanks for the extensive testing!
    33
    4 You're welcome. Thanks again for making these improvements.
     4You're welcome. Thanks again for making these improvements. Let me know if you want further testing of new patches on this issue.
    55 
    66> I did already address excessive memory use in the revisions list, removing the content from the retrieved values was a big part of the memory gains, I think all the remaining fields are required.
     
    1010> Are you seeing issues on the revisions interface screen? I have mainly been testing on the post edit screen.
    1111
    12 As reported, from incidental testing, I see unexpectedly high memory use on the revisions screen with this big page. I would expect the revisions screen should use the memory needed for the revisions list (<1MB by my estimate) plus twice the biggest post (again < 1MB total in my test). So, for my test situation, I would expect about 28MB to be used, not 89MB. So, about 61MB of memory beyond the minimum possible needed seems to be used on the revisions screen.
     12As reported, from incidental testing, I see unexpectedly high memory use on the revisions screen with this big page with many revisions. It otherwise works OK. I would expect the revisions screen should use the memory needed for the revisions list (<1MB by my estimate) plus twice the biggest post (again < 1MB total in my test). So, for my test situation, I would expect about 28MB to be used, not 89MB. So, about 61MB of memory beyond the minimum possible needed seems to be used on the revisions screen.
    1313
    14 It looks like issue #25233 is related to this one in a similar way as issue #24958 is. Again the difference is that the other issue is on the revision list itself; specially how the "revisions metabox suffers from performance degradation when ... a large amount of revisions (e.g. 600+) is achieved on a post." That is the same thing I am seeing here, assuming "revisions metabox" is referring to the one on the bottom of the editor screen. And that issue also includes a comment from you referring to issue #25123, on perhaps replacing the revisions metabox with a plugin. Although other proposed solutions are to selectively load posts as needed for comparison on the revisions screen.
     14It looks like issue #25233 is related to this one in a similar way as issue #24958 is. Again the difference is that the other issue is on the revision list itself; especially how the "revisions metabox suffers from performance degradation when ... a large amount of revisions (e.g. 600+) is achieved on a post." That is the same thing I am seeing here, assuming "revisions metabox" is referring to the one on the bottom of the editor screen. And that issue also includes a comment from you referring to issue #25123, on perhaps replacing the revisions metabox with a plugin. Although other proposed solutions are to selectively load posts as needed for comparison on the revisions screen.
    1515
    1616Presumably, removing the revisions metabox list from the bottom of the editor screen would indeed fix the rest of the memory use issue in the editor for large numbers of big posts? Improving the revisions list to use the new wp_get_post_revisions_details would also presumably address the issue too.