![(please configure the [header_logo] section in trac.ini)](/chrome/site/your_project_logo.png){kind=logo}
Changes between Version 1 and Version 2 of Ticket #34560, comment 30
- Timestamp:
- 11/10/2015 02:02:48 PM (11 years ago)
Legend:
- Unmodified
- Added
- Removed
- Modified
-
Ticket #34560, comment 30
v1 v2 17 17 It would not surprise me if there were other problematical uses of "wp_get_post_revisions", but [https://github.com/WordPress/WordPress/search?q=wp_get_post_revisions code review for that] could perhaps become a new issue. 18 18 19 One remaining concern is the one in comment 17 referencing issue #25233 (the second concern under "Possible bottlenecks") about WordPress needing to load all revisions to upgrade them. Does that concern apply here? I do not see such code in the [https://github.com/WordPress/WordPress/blob/4.3-branch/wp-includes/revision.php 4.3 version of that function]. There is a separate "_wp_upgrade_revisions_of_post" function in that file. It seems to [https://github.com/WordPress/WordPress/search?q=_wp_upgrade_revisions_of_post be called] separately when the edit process is started via edit_post (code below). Based on inspecting the code for WordPress 4.3 on GitHub, I do not think that concern does not apply here far as the patch itself goes -- but someone else should review that just in case to ensure there is no risk of data corruption.19 One remaining concern is the one in comment 17 referencing issue #25233 by @jkudish (the second concern under "Possible bottlenecks") about WordPress needing to load all revisions to upgrade them. Does that concern apply here? I do not see such code in the [https://github.com/WordPress/WordPress/blob/4.3-branch/wp-includes/revision.php 4.3 version of that function]. There is a separate "_wp_upgrade_revisions_of_post" function in that file. It seems to [https://github.com/WordPress/WordPress/search?q=_wp_upgrade_revisions_of_post be called] separately when the edit process is started via edit_post (code below). Based on inspecting the code for WordPress 4.3 on GitHub, I do not think that concern does not apply here far as the patch itself goes -- but someone else should review that just in case to ensure there is no risk of data corruption. 20 20 21 21 See this code in [https://github.com/WordPress/WordPress/blob/4.3-branch/wp-admin/includes/post.php includes/post.php] to understand what the concern may be: … … 35 35 That fragment of code seems to call "wp_get_post_revisions" twice, btw. People seem to like calling that function a lot. LOL. :-) 36 36 37 Still, what are the differences between the edit_post function in post.php and the code in edit_form_advanced.php? Perhaps there is some other bug (or maybe two bugs, one on memory in edit_post which calls wp_get_post_revisions when it may not need to, and one on_wp_upgrade_revisions_of_post not being called in edit-form-advanced.php ) which could become new issues issue related to differences between those two functions regarding upgrading revisions?37 Still, what are the differences between the edit_post function in post.php and the code in edit_form_advanced.php? Perhaps there is some other bug which could become new issues issue related to differences between those two functions regarding upgrading revisions? Or maybe there are two separate new issues -- one definite issue on memory use for edit_post which calls wp_get_post_revisions when it may not need to, and another issue perhaps on _wp_upgrade_revisions_of_post not being called in edit-form-advanced.php when it should?
