WordPress.org

Make WordPress Core

Changes between Version 3 and Version 4 of Ticket #34560, comment 30


Ignore:
Timestamp:
11/10/2015 02:29:37 PM (4 years ago)
Author:
pdfernhout
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #34560, comment 30

    v3 v4  
    3333}}}
    3434
    35 That fragment of code seems to call "wp_get_post_revisions" twice, btw. People really seem to like calling that function a lot. LOL. :-)
     35That fragment of code seems to call "wp_get_post_revisions" twice, btw. '''Update:''' Because the arguments are different in the first call (posts_per_page of 1), perhaps the second call is definitely needed?
    3636
    37 Still, what are the differences between the edit_post function in post.php and the code in edit_form_advanced.php? Perhaps there is some other bug which could become new issues issue related to differences between those two functions regarding upgrading revisions? Or maybe there are two separate new issues -- one definite issue on memory use for edit_post which calls wp_get_post_revisions when it may not need to, and another issue perhaps on _wp_upgrade_revisions_of_post not being called in edit-form-advanced.php when it should?
     37Still, what are the differences between the edit_post function in post.php and the code in edit_form_advanced.php? Perhaps there is some other bug which could become new issues issue related to differences between those two functions regarding upgrading revisions? Or maybe there are two separate new issues -- one possible issue on memory use for edit_post which calls wp_get_post_revisions twice (but maybe needs to, or maybe the first call should be different and more specialized), and another issue perhaps on _wp_upgrade_revisions_of_post not being called in edit-form-advanced.php when it should?