WordPress.org

Make WordPress Core

Changes between Initial Version and Version 1 of Ticket #34561, comment 20


Ignore:
Timestamp:
12/14/2015 07:02:52 AM (4 years ago)
Author:
Otto42
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #34561, comment 20

    initial v1  
    11The embed template is pretty awful as-is. Replacing it entirely is pretty much the only option available for customizing it, and the only route that anybody is going to actually take, at present.
    22
    3 Either the entire thing should be abstracting into sections and pieces and every element made filterable, or the idea should be scrapped in favor of wholesale replacement. As it stands, you basically have to choose one or the other.
     3Either the entire thing should be abstracted into sections and pieces and every element made filterable, or the idea should be scrapped in favor of wholesale replacement. As it stands, you basically have to choose one or the other.
    44
    55All that rectangular/square/attachment ID logic needs to be eliminated entirely, and moved into functions elsewhere. All that is needed in the template is a filter to put an image URL in. Anything more than that is super overkill.