Possible Bug on Customizer Ordering Method

[bordoni]

I was looking at the code for Customize Manager class, and found a possible typo on the ordering method; Link to the possible place where the typo might be.

https://core.trac.wordpress.org/browser/trunk/src/wp-includes/class-wp-customize-manager.php#L1305

Am I right here? I think the correct should be what the patch attached changes.

[bordoni]

Patch Fixing the possible typo

[SergeyBiryukov]

Introduced in [30214].

[westonruter]

@bordoni wow, good catch! How did you come across it? Did you notice a defect in the behavior or was it found through studying the codebase?

[bordoni]

I was working on something that required a Priority ordering for a The Events Calendar feature, I knew that the Customize would have something like that in place because I've worked with it previously.

So when I was implementing it to the plugin I saw that it was weird, a duplicate $a there, so I checked on trunk and the code was still there since I found it on 4.3.

Never came across the problem on the Customize itself =).

[westonruter]

It turns out that (as far as I can tell) this bug will never be apparent in the Customzier UI because wp.customize.utils.prioritySort did _not_ have this bug, and now that the UI is added via JS, the initial PHP sorting is pretty much irrelevant. It's a good catch regardless.

[westonruter]

In 35553:

Customize: Fix typo in WP_Customize_Manager::_cmp_priority() which caused unstable sorting for same-priority constructs in PHP.

The issue, however, does not manifest in the UI because the UI is now built via JS and the wp.customize.utils.prioritySort() algorithm did not have the same typo.

Props bordoni, westonruter.
Fixes #34594.