![(please configure the [header_logo] section in trac.ini)](/chrome/site/your_project_logo.png){kind=logo}
Opened 11 years ago
Closed 11 years ago
#34594 closed defect (bug) (fixed)
Possible Bug on Customizer Ordering Method
| Reported by: | bordoni | Owned by: | westonruter |
|---|---|---|---|
| Priority: | normal | Milestone: | 4.4 |
| Component: | Customize | Version: | 4.1 |
| Severity: | normal | Keywords: | has-patch commit |
| Cc: | Focuses: |
Description
I was looking at the code for Customize Manager class, and found a possible typo on the ordering method; Link to the possible place where the typo might be.
https://core.trac.wordpress.org/browser/trunk/src/wp-includes/class-wp-customize-manager.php#L1305
Am I right here? I think the correct should be what the patch attached changes.
Attachments (2)
Change History (8)
#2
@
11 years ago
- Milestone Awaiting Review → 4.4
- Owner set to
- Status new → assigned
- Version trunk → 4.1
Introduced in [30214].
#3
@
11 years ago
- Status assigned → reviewing
@bordoni wow, good catch! How did you come across it? Did you notice a defect in the behavior or was it found through studying the codebase?
#4
@
11 years ago
I was working on something that required a Priority ordering for a The Events Calendar feature, I knew that the Customize would have something like that in place because I've worked with it previously.
So when I was implementing it to the plugin I saw that it was weird, a duplicate $a there, so I checked on trunk and the code was still there since I found it on 4.3.
Never came across the problem on the Customize itself =).
#5
@
11 years ago
- Keywords commit added
It turns out that (as far as I can tell) this bug will never be apparent in the Customzier UI because wp.customize.utils.prioritySort did _not_ have this bug, and now that the UI is added via JS, the initial PHP sorting is pretty much irrelevant. It's a good catch regardless.
Patch Fixing the possible typo