WordPress.org

Make WordPress Core

Opened 5 years ago

Closed 5 years ago

#34598 closed defect (bug) (fixed)

Avoid using HTML tags in translation strings (wp-admin/includes/network.php)

Reported by: ramiy Owned by: SergeyBiryukov
Milestone: 4.4 Priority: normal
Severity: normal Version:
Component: I18N Keywords: has-patch
Focuses: Cc:

Description

See the attached patch.

Attachments (2)

34598.patch (3.6 KB) - added by ramiy 5 years ago.
34598.2.patch (1.0 KB) - added by ramiy 5 years ago.

Download all attachments as: .zip

Change History (9)

@ramiy
5 years ago

#1 @ramiy
5 years ago

  • Keywords has-patch added

#2 @SergeyBiryukov
5 years ago

  • Milestone changed from Awaiting Review to 4.4

#3 @SergeyBiryukov
5 years ago

  • Owner set to SergeyBiryukov
  • Resolution set to fixed
  • Status changed from new to closed

In 35552:

Remove <code> tags from translatable strings in wp-admin/includes/network.php.

Add translator comments.

Props ramiy.
Fixes #34598.

#4 @ramiy
5 years ago

  • Resolution fixed deleted
  • Status changed from closed to reopened

One more fix - moving extra code out of the strings.

See the attached patch.

@ramiy
5 years ago

#5 follow-up: @SergeyBiryukov
5 years ago

/* That&#8217;s all, stop editing! Happy blogging. */

This line can be translated in localized wp-config-sample.php files (we translate it in Russian package), so I think we should leave it as is (or at least move it to a separate string, though it's not used anywhere else).

#6 in reply to: ↑ 5 @ramiy
5 years ago

Replying to SergeyBiryukov:

/* That&#8217;s all, stop editing! Happy blogging. */

This line can be translated in localized wp-config-sample.php files (we translate it in Russian package), so I think we should leave it as is (or at least move it to a separate string, though it's not used anywhere else).

Didn't know you can translate the wp-config-sample.php file. If this is the case, let's skip this fix and leave the string as it is.

#7 @SergeyBiryukov
5 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed
Note: See TracTickets for help on using tickets.