![(please configure the [header_logo] section in trac.ini)](/chrome/site/your_project_logo.png){kind=logo}
Opened 11 years ago
Closed 11 years ago
#34605 closed defect (bug) (fixed)
Typo in wp-login.php
| Reported by: | slaFFik | Owned by: | SergeyBiryukov |
|---|---|---|---|
| Priority: | normal | Milestone: | 4.4 |
| Component: | Login and Registration | Version: | |
| Severity: | normal | Keywords: | has-patch |
| Cc: | Focuses: |
Description
I believe should be reset is more appropriate.
$message = __('Someone requested that the password be reset for the following account:') . "\r\n\r\n";
I'm not a native English speaker, though.
Attachments (2)
Change History (13)
#2
@
11 years ago
Ok, thanks for explaining. I though passive voice here would be overkill.
#4
in reply to: ↑ 1
;
follow-ups:
↓ 5
↓ 6
@
11 years ago
Replying to boonebgorges:
'requested that x be reset' is the subjective mood, which is appropriate here.
What about 'Someone requested a password reset for the following account'?
#5
in reply to: ↑ 4
@
11 years ago
Replying to SergeyBiryukov:
Replying to boonebgorges:
'requested that x be reset' is the subjective mood, which is appropriate here.
What about 'Someone requested a password reset for the following account'?
This is fine. To my ear, it's a bit less literary. Maybe that's a good thing for a "Cheatin', uh?" system like ours :) If the current phrasing is awkward for non-native speakers, let's change it.
#6
in reply to: ↑ 4
@
11 years ago
- Keywords needs-patch added
- Milestone → Awaiting Review
- Resolution invalid
- Status closed → reopened
Replying to SergeyBiryukov:
Replying to boonebgorges:
'requested that x be reset' is the subjective mood, which is appropriate here.
What about 'Someone requested a password reset for the following account'?
+1
#7
@
11 years ago
- Keywords has-patch added; needs-patch removed
I agree, I like the wording Someone requested a password reset for the following account: a lot better.
#8
@
11 years ago
Actually, the more I say this to myself outloud, I think Someone has requested a password reset for the following account: sounds better. 34605-2.diff has that minor change.
Thanks for the suggestion, slaFFik!
'Someone requested that the password be reset' is better English than 'Someone requested that the password should be reset'. 'requested that x be reset' is the subjective mood, which is appropriate here.