Make WordPress Core

Opened 10 years ago

Closed 10 years ago

#34605 closed defect (bug) (fixed)

Typo in wp-login.php

Reported by: slaffik's profile slaFFik Owned by: sergeybiryukov's profile SergeyBiryukov
Milestone: 4.4 Priority: normal
Severity: normal Version:
Component: Login and Registration Keywords: has-patch
Focuses: Cc:

Description

I believe should be reset is more appropriate.

$message = __('Someone requested that the password be reset for the following account:') . "\r\n\r\n";

I'm not a native English speaker, though.

Attachments (2)

34605.diff (622 bytes) - added by obrienlabs 10 years ago.
34605-2.diff (626 bytes) - added by obrienlabs 10 years ago.

Download all attachments as: .zip

Change History (13)

#1 follow-up: @boonebgorges
10 years ago

  • Milestone Awaiting Review deleted
  • Resolution set to invalid
  • Status changed from new to closed

Thanks for the suggestion, slaFFik!

'Someone requested that the password be reset' is better English than 'Someone requested that the password should be reset'. 'requested that x be reset' is the subjective mood, which is appropriate here.

#2 @slaFFik
10 years ago

Ok, thanks for explaining. I thought passive voice here would be overkill.

Last edited 10 years ago by slaFFik (previous) (diff)

#3 @SergeyBiryukov
10 years ago

  • Component changed from General to Login and Registration

#4 in reply to: ↑ 1 ; follow-ups: @SergeyBiryukov
10 years ago

Replying to boonebgorges:

'requested that x be reset' is the subjective mood, which is appropriate here.

What about 'Someone requested a password reset for the following account'?

#5 in reply to: ↑ 4 @boonebgorges
10 years ago

Replying to SergeyBiryukov:

Replying to boonebgorges:

'requested that x be reset' is the subjective mood, which is appropriate here.

What about 'Someone requested a password reset for the following account'?

This is fine. To my ear, it's a bit less literary. Maybe that's a good thing for a "Cheatin', uh?" system like ours :) If the current phrasing is awkward for non-native speakers, let's change it.

#6 in reply to: ↑ 4 @DrewAPicture
10 years ago

  • Keywords needs-patch added
  • Milestone set to Awaiting Review
  • Resolution invalid deleted
  • Status changed from closed to reopened

Replying to SergeyBiryukov:

Replying to boonebgorges:

'requested that x be reset' is the subjective mood, which is appropriate here.

What about 'Someone requested a password reset for the following account'?

+1

@obrienlabs
10 years ago

#7 @obrienlabs
10 years ago

  • Keywords has-patch added; needs-patch removed

I agree, I like the wording Someone requested a password reset for the following account: a lot better.

@obrienlabs
10 years ago

#8 @obrienlabs
10 years ago

Actually, the more I say this to myself outloud, I think Someone has requested a password reset for the following account: sounds better. 34605-2.diff has that minor change.

#9 @SergeyBiryukov
10 years ago

  • Milestone changed from Awaiting Review to 4.4

#10 @slaFFik
10 years ago

Sigh... that could be my first patch to WordPress and a mention in release notes.
Seems, not this time, as @obrienlabs did the job ;)

#11 @SergeyBiryukov
10 years ago

  • Owner set to SergeyBiryukov
  • Resolution set to fixed
  • Status changed from reopened to closed

In 35559:

Reset Password: Improve wording for a string used in password reset email.

Props obrienlabs.
Fixes #34605.

Note: See TracTickets for help on using tickets.