Changes between Initial Version and Version 1 of Ticket #34608, comment 3
- Timestamp:
- 04/08/2016 12:39:35 PM (5 years ago)
Legend:
- Unmodified
- Added
- Removed
- Modified
-
Ticket #34608, comment 3
initial v1 2 2 > I just added a patch. I hope I did implement the two suggested methods well. 3 3 4 I think that `$this->name` is just the slug, and `translate_ role_name()` needs to be passed the `display_name` (which isn't on the `WP_Role` object). So we also need to change things so that `WP_Role` is constructed with the display name too, or else have `WP_Role` retrieve it from `WP_Roles::get_names()`. (It's all very confusing, I know!)4 I think that `$this->name` is just the slug, and `translate_user_role()` needs to be passed the `display_name` (which isn't on the `WP_Role` object). So we also need to change things so that `WP_Role` is constructed with the display name too, or else have `WP_Role` retrieve it from `WP_Roles::get_names()`. (It's all very confusing, I know!)