WordPress.org

Make WordPress Core

Opened 5 years ago

Closed 5 years ago

Last modified 5 years ago

#34613 closed defect (bug) (fixed)

Accessibility improvements while editing categories and tags

Reported by: garusky Owned by: afercia
Milestone: 4.4 Priority: normal
Severity: normal Version: 4.3
Component: Administration Keywords: has-patch has-screenshots
Focuses: ui, accessibility, javascript Cc:

Description

The categories and tags quick edit form could be improved a bit for accessibility.

  • in the quick edit form both cancel and update are anchors. That's not a good practice because they are buttons and not links.
  • When keyboard or screen reader users press cancel or update the focus is moved on top of the page. Some browser like Firefox fix this issue natively but Chrome and others still have the problem.
  • There is no audible message for screen reader users when they press update.

We are working on a patch at the first italian Contributor Day.
Patch coming soon :)

Attachments (3)

quickedit-accessibility-improvements.png (647.5 KB) - added by garusky 5 years ago.
34613.patch (3.7 KB) - added by garusky 5 years ago.
34613.2.patch (4.3 KB) - added by afercia 5 years ago.

Download all attachments as: .zip

Change History (12)

#1 @johnbillion
5 years ago

  • Keywords needs-patch added

@garusky
5 years ago

#2 @garusky
5 years ago

  • Keywords has-patch has-screenshots added; needs-patch removed

In the proposed patch we try to address the issues listed above.
Any feedback more than welcome.

This ticket was mentioned in Slack in #accessibility by garusky. View the logs.


5 years ago

#4 @afercia
5 years ago

  • Owner set to afercia
  • Status changed from new to assigned

#5 @afercia
5 years ago

First accessibility patch at the first Italian WordPress Contributor Day on Saturday November 7th in Milan :) Looks good to me, needs just a couple of tweaks.

@afercia
5 years ago

#6 @afercia
5 years ago

In the refreshed patch:

  • since the "Cancel" and "Update" controls are now buttons, there's no need for return false because there's no default action to prevent.
  • some error strings from the AJAX response may contain HTML entities and can't be used for the wp.a11y.speak() message since screen readers will read things like “ character by character (see also screenshot below); a simple fix is to get the same text after it is used for the error span element and entities are already converted in characters

https://cldup.com/yxLSdwcI_C.png

Other things the proposed patch does:

  • when clicking on "Cancel" and "Update", moves focus back to the term's title
  • dispatches feedback messages to wp.a11y.speak() in case of success or errors

Note for committers: need to retrieve the username of one of the contributors before commit :)

This ticket was mentioned in Slack in #core-editor by afercia. View the logs.


5 years ago

#8 @afercia
5 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 35605:

Accessibility: improvements for the taxonomies Quick Edit form.

Changes the "Cancel" and "Update" controls in buttons for better semantics and
accessibility. On cancel and successful saving, moves focus back to the term title
to avoid a focus loss. Dispatches error and success messages to wp.a11y.speak
to give assistive technologies users an audible feedback.

Patch prepared at #wpcdit, first Italian WordPress Contributor Day.

Props garusky, chiara_09.
Fixes #34613.

#9 @netweb
5 years ago

  • Milestone changed from Awaiting Review to 4.4
Note: See TracTickets for help on using tickets.