Avoid using HTML tags in translation strings (wp-admin/includes/upgrade.php)

[ramiy]

Found a wrong use of str_replace() in translations strings. We should use sprintf() instead.

See the attached patch fixing this issue.

[ramiy]

The second patch better - this way we avoid using HTML tags in the translation strings.

[SergeyBiryukov]

The same string is also used in tags/4.3.1/src/wp-admin/includes/schema.php#L977​.

It's a site option used for newly created sites in Multisite. We can't remove str_replace() here, it would still be needed for back-compat with the stored text.

[ramiy]

Can we use sprintf() strings in both places?

[SergeyBiryukov]

Replying to ramiy:

Can we use sprintf() strings in both places?

Haven't tested yet, but I think it was done this way because network_home_url() or get_current_site() is not available yet when populate_network() run for the first time.

[ramiy]

OK, I didn't know that. I guess you can close this ticket.

[SergeyBiryukov]

Replying to ramiy:

Can we use sprintf() strings in both places?

On second thought, I think 34619.3.patch​ might work.

We still need str_replace() for back-compat, but at least the string would now be correct.

[SergeyBiryukov]

In 35614:

Remove non-translatable HTML code from the first post content in populate_network() and wp_install_defaults().

Add translator comment.

Props ramiy.
Fixes #34619.