WordPress.org

Make WordPress Core

Opened 5 years ago

Closed 4 years ago

#34633 closed defect (bug) (fixed)

X-pingback header should be generated the same as rel="pingback" link

Reported by: mark-k Owned by: jorbin
Milestone: 4.7 Priority: normal
Severity: normal Version: 2.0
Component: Pings/Trackbacks Keywords: has-patch
Focuses: Cc:

Description

Right now the generation of the url for X-pingback is done by a call to get_bloginfo API while the generation of the rel="pingback" link is done by calling bloginf API.
The difference between the two is that the later can be filtered which means that in theory the X-pingback URL will be different than the one in rel="pingback link.

I suggest using the bloginfo API for both as I don't see any reason not to be able to filter the url (right now it points to the XMLRPC end point but people might want to use a different one for pingback to have a distinction in treatment between remote management and commenting)

Attachments (1)

34633.diff (519 bytes) - added by dshanske 5 years ago.

Download all attachments as: .zip

Change History (7)

@dshanske
5 years ago

#1 @dshanske
5 years ago

  • Keywords has-patch added

I can see good reasons to allow this to be filtered uniformly. One being the possibility of delegating pingback processing to a service function outside of WordPress itself.

This ticket was mentioned in Slack in #core-comments by dshanske. View the logs.


5 years ago

This ticket was mentioned in Slack in #core-comments by dshanske. View the logs.


5 years ago

This ticket was mentioned in Slack in #core by dshanske. View the logs.


4 years ago

#5 @SergeyBiryukov
4 years ago

  • Milestone changed from Awaiting Review to 4.7

#6 @jorbin
4 years ago

  • Owner set to jorbin
  • Resolution set to fixed
  • Status changed from new to closed

In 38671:

Pings/Trackbacks: Add filter argument to fetching of pingbacks_url in X-pingback header

It is possible to delegate pingback processing to a service function outside of WordPress itself. All other calls in default themes (and likely other themes) uses bloginfo which automatically adds the filter argument of "display". This adds consistency.

Props dshanske.
Fixes #34633.

Note: See TracTickets for help on using tickets.