Make WordPress Core

Opened 15 years ago

Closed 15 years ago

Last modified 8 months ago

#3464 closed defect (bug) (fixed)

Category delete AYS prompt incorrectly states outcome of category deletion

Reported by: markjaquith's profile markjaquith Owned by: rob1n's profile rob1n
Milestone: 2.2 Priority: low
Severity: minor Version: 2.1
Component: Administration Keywords: has-patch commit
Focuses: Cc:

Description

When deleting a category using AJAX, the AYS prompt tells the user that all the posts will go into the default post category and all links will go into the default link category. This is only the case if the deleted category was the only category for that post.

Not sure if it's worth making that distinction in the AYS or if there's even a good way to word such a thing.

"All posts that were only assigned to this category will be assigned to the "Uncategorized" category. All links that were only assigned to this category will be assigned to the "Blogroll" category" ?

Attachments (5)

cat-delete-ays.png (25.4 KB) - added by markjaquith 15 years ago.
screenshot of AYS
cat-delete-note.png (8.3 KB) - added by markjaquith 15 years ago.
category delete note
cat-delete-ays.diff (2.8 KB) - added by postalservice14 15 years ago.
Patch file
3464.diff (2.9 KB) - added by rob1n 15 years ago.
3464.2.diff (2.9 KB) - added by rob1n 15 years ago.
Change bookmarks to links.

Download all attachments as: .zip

Change History (18)

@markjaquith
15 years ago

screenshot of AYS

@markjaquith
15 years ago

category delete note

#1 @markjaquith
15 years ago

Actually, look at the cat-delete-note.png attachment... there is also an HTML note that incorrectly states the outcome.

#2 @postalservice14
15 years ago

  • Owner changed from anonymous to postalservice14
  • Status changed from new to assigned

@postalservice14
15 years ago

Patch file

#3 @postalservice14
15 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

Let me know if you think the wording should be any different.

John

#4 @foolswisdom
15 years ago

  • Keywords has-patch commit added
  • Resolution fixed deleted
  • Status changed from closed to reopened

Hi John,
Thanks for the patch, don't market tickets fixed though. Someone with commit access will when a fix is checked in.
Wording looks good.

#5 @markjaquith
15 years ago

Instead, posts only in the deleted category are set to the category <strong>%s</strong> and links only set to this category are set to <strong>%s</strong>

I'm not 100% on this. How about:

Instead, posts that were only assigned to the deleted category are set to the category <strong>%s</strong> and links that were only assigned to the deleted category are set to <strong>%s</strong>

That makes the wording more consistent with the wording in the JS alert() portion of your patch, which I like.

#6 @foolswisdom
15 years ago

  • Keywords has-patch commit removed

#7 @rob1n
15 years ago

  • Owner changed from postalservice14 to rob1n
  • Status changed from reopened to new

#8 @rob1n
15 years ago

  • Status changed from new to assigned

I'll work on a new patch incorporating MarkJaquith's fixes, as the reporter seems to be MIA.

@rob1n
15 years ago

#9 @rob1n
15 years ago

  • Keywords has-patch commit added

Patch refreshed.

#10 @ryan
15 years ago

I think there are some bookmark references lingering. Let's change those to links.

#11 @rob1n
15 years ago

  • Keywords has-patch commit removed

On it.

@rob1n
15 years ago

Change bookmarks to links.

#12 @rob1n
15 years ago

  • Keywords has-patch commit added

#13 @ryan
15 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

(In [5033]) Rephrase category delete AYS prompt. Props rob1n. fixes #3464

Note: See TracTickets for help on using tickets.