Make WordPress Core

Changes between Initial Version and Version 1 of Ticket #34657, comment 5


Ignore:
Timestamp:
10/11/2016 02:48:43 AM (8 years ago)
Author:
welcher
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #34657, comment 5

    initial v1  
    1 I'm not sure we should be dying if `$_POST['menu']` is not set. That block is meant to check whether the user has the capability to do this and it shouldn't ( in my opinion ) care if that item is set.
     1Thanks for the patch!
     2
     3Just one thing - I'm not sure we should be dying if `$_POST['menu']` is not set. That block is meant to check whether the user has the capability to do this and it shouldn't ( in my opinion ) care if that item is set.
    24
    35If we're just wanting to be sure that there is a value passed to the `wp_save_nav_menu_items` it might be a good idea to use a ternary instead.