WordPress.org
Get WordPress

Make WordPress Core

Opened 9 years ago

Closed 9 years ago

#34667 closed enhancement (invalid)

Use RTL Plugin banners when appropriate

Reported by: otto42's profile Otto42 Owned by:
Milestone: Priority: normal
Severity: normal Version:
Component: Plugins Keywords:
Focuses: Cc:

Description

The Plugins directory now supports separate banners for RTL languages.

​https://meta.trac.wordpress.org/ticket/757

The plugin info API does return this information. Core should support them as well.

Patch incoming.

Attachments (2)

34667.patch​ (2.0 KB) - added by Otto42 9 years ago.
Show RTL plugin banners when available. Also eliminate strange logic for low/high banners.
34667.2.patch​ (2.1 KB) - added by Otto42 9 years ago.
Alternate patch to keep the inline styling formatted in the html source, and which adds support for high-dpi cases in browsers like Firefox and Opera

Download all attachments as: .zip

Change History (6)

@Otto42
9 years ago

Show RTL plugin banners when available. Also eliminate strange logic for low/high banners.

#1 @Otto42
9 years ago

Note for testing: The Pluginception plugin has been updated with RTL banners for both high and low cases, so the image can be seen to be flipped when using RTL languages (such as Hebrew).

@Otto42
9 years ago

Alternate patch to keep the inline styling formatted in the html source, and which adds support for high-dpi cases in browsers like Firefox and Opera

This ticket was mentioned in ​Slack in #core by otto42. ​View the logs.
9 years ago

#4 @Otto42
9 years ago

  • Milestone Awaiting Review deleted
  • Resolution set to invalid
  • Status changed from new to closed

We will handle this in the API response instead.

Note: See TracTickets for help on using tickets.