WordPress.org

Make WordPress Core

Opened 4 years ago

Closed 4 years ago

Last modified 4 years ago

#34680 closed defect (bug) (fixed)

Comment List translation no-working

Reported by: hnle Owned by: SergeyBiryukov
Milestone: 4.4 Priority: normal
Severity: normal Version: 4.4
Component: I18N Keywords: needs-patch
Focuses: administration Cc:

Description

in #31859 ([34424]), <span class="count">(%s)</span> move out from translation string. but, this made broken translations.
because, this string will use in translate_nooped_plural as nooped_plural but this not include <span class="count">(%s)</span> .

We should replace it after translated.

Attachments (2)

34680.diff (3.2 KB) - added by hnle 4 years ago.
34680-2.diff (957 bytes) - added by hnle 4 years ago.

Download all attachments as: .zip

Change History (10)

@hnle
4 years ago

#1 @hnle
4 years ago

  • Keywords has-patch added

#2 @hnle
4 years ago

Note: This bug is reported by @tg29359 in https://ja.forums.wordpress.org/topic/156583

#3 @SergeyBiryukov
4 years ago

  • Milestone changed from Awaiting Review to 4.4
  • Owner set to SergeyBiryukov
  • Status changed from new to reviewing

#4 @SergeyBiryukov
4 years ago

  • Resolution set to fixed
  • Status changed from reviewing to closed

In 35670:

I18N: After [34424], replace the placeholder with comments count after translate_nooped_plural() runs, not before.

Props hnle.
Fixes #34680.

#5 @ocean90
4 years ago

  • Keywords needs-patch added; has-patch removed

[35670] changed the CSS class for the pending comments count from pending to moderated which broke the JS code for live-updating.

#6 @SergeyBiryukov
4 years ago

  • Resolution fixed deleted
  • Status changed from closed to reopened

#7 @SergeyBiryukov
4 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In 35726:

Comments: After [35670], change the CSS class for the pending comments count back to moderated.

Fixes #34680.

@hnle
4 years ago

#8 @hnle
4 years ago

sorry, miss.

Version 0, edited 4 years ago by hnle (next)
Note: See TracTickets for help on using tickets.