WordPress.org

Make WordPress Core

Opened 5 years ago

Closed 5 years ago

#34684 closed defect (bug) (fixed)

Add translators comments to wp-admin/includes/class-wp-filesystem-ssh2.php

Reported by: ramiy Owned by: SergeyBiryukov
Milestone: 4.4 Priority: normal
Severity: normal Version:
Component: I18N Keywords: has-patch
Focuses: Cc:

Description

The wp-admin/includes/class-wp-filesystem-ssh2.php file has a few translation strings that I didn't know how to translate. In the attached patch I added translators comments for better context.

Attachments (2)

34684.patch (2.7 KB) - added by ramiy 5 years ago.
34684-text-change.patch (2.6 KB) - added by ramiy 5 years ago.

Download all attachments as: .zip

Change History (9)

@ramiy
5 years ago

#1 @ramiy
5 years ago

Also, It would be smart to replace both %1$s:%2$s strings with a simple %s, moving the logic from the translation string to the code.

Old:

sprintf(
	/* translators: 1: hostname 2: port */
	__( 'Failed to connect to SSH2 Server %1$s:%2$s' ),
	$this->options['hostname'],
	$this->options['port']
)

New:

sprintf(
	/* translators: %s: hostname:port */
	__( 'Failed to connect to SSH2 Server %s' ),
	$this->options['hostname'].':'.$this->options['port']
)

See the attached patch.

#2 @ramiy
5 years ago

  • Keywords has-patch added

#3 @SergeyBiryukov
5 years ago

  • Milestone changed from Awaiting Review to 4.4
  • Owner set to SergeyBiryukov
  • Status changed from new to reviewing

#4 @SergeyBiryukov
5 years ago

In 35661:

I18N: Add translator comments for strings in wp-admin/includes/class-wp-filesystem-ssh2.php.

Props ramiy.
See #34684.

#5 @SergeyBiryukov
5 years ago

In 35662:

I18N: Add translator comments for strings in wp-admin/includes/class-wp-filesystem-base.php.

See #34684.

#6 @SergeyBiryukov
5 years ago

In 35663:

I18N: Add translator comments for strings in wp-admin/includes/class-wp-filesystem-ftpext.php.

See #34684.

#7 @SergeyBiryukov
5 years ago

  • Resolution set to fixed
  • Status changed from reviewing to closed

In 35664:

I18N: Add translator comments for strings in wp-admin/includes/class-wp-filesystem-ftpsockets.php.

Fixes #34684.

Note: See TracTickets for help on using tickets.