WordPress.org
Get WordPress

Make WordPress Core

Opened 11 years ago

Closed 11 years ago

#34688 closed enhancement (fixed)

Missing unit tests for WP_Locale

Reported by: realloc Owned by: johnbillion
Priority: normal Milestone: 4.5
Component: I18N Version:
Severity: normal Keywords: has-patch has-unit-tests
Cc: Focuses:

Description

There are no unit tests at all for the class WP_Locale, so I just began to write them.

Attachments (4)

34688.patch​ (1.8 KB ) - added by realloc 11 years ago.
Tests for WP_Locale
34688.2.patch​ (1.4 KB ) - added by realloc 11 years ago.
Tests for WP_Locale - Corrected patch
34688.3.patch​ (1.4 KB ) - added by realloc 11 years ago.
Fix: ( 'am' ) instead of _( 'am' )
34688.diff​ (6.0 KB ) - added by swissspidy 11 years ago.

Download all attachments as: .zip

Change History (9)

@realloc
11 years ago

Tests for WP_Locale

@realloc
11 years ago

Tests for WP_Locale - Corrected patch

@realloc
11 years ago

Fix: ( 'am' ) instead of _( 'am' )

#1 @johnbillion
11 years ago

  • Keywords has-patch has-unit-tests added
  • Version trunk

#2 @johnbillion
11 years ago

  • Milestone Awaiting Review → Future Release

@swissspidy
11 years ago

#3 @swissspidy
11 years ago

  • Milestone Future Release → 4.5

34688.diff​ tests all public methods with possible values.

#4 @swissspidy
11 years ago

@ocean90 You got some experience with i18n/WP_Locale. Anything else you would test here?

#5 @johnbillion
11 years ago

  • Owner set to johnbillion
  • Resolution → fixed
  • Status new → closed

In 36292:

I18N: Introduce tests for WP_Locale.

Props realloc, swissspidy
Fixes #34688

Note: See TracTickets for help on using tickets.