WordPress.org
Get WordPress

Make WordPress Core

Opened 9 years ago

Closed 9 years ago

#34688 closed enhancement (fixed)

Missing unit tests for WP_Locale

Reported by: realloc's profile realloc Owned by: johnbillion's profile johnbillion
Milestone: 4.5 Priority: normal
Severity: normal Version:
Component: I18N Keywords: has-patch has-unit-tests
Focuses: Cc:

Description

There are no unit tests at all for the class WP_Locale, so I just began to write them.

Attachments (4)

34688.patch​ (1.8 KB) - added by realloc 9 years ago.
Tests for WP_Locale
34688.2.patch​ (1.4 KB) - added by realloc 9 years ago.
Tests for WP_Locale - Corrected patch
34688.3.patch​ (1.4 KB) - added by realloc 9 years ago.
Fix: ( 'am' ) instead of _( 'am' )
34688.diff​ (6.0 KB) - added by swissspidy 9 years ago.

Download all attachments as: .zip

Change History (9)

@realloc
9 years ago

Tests for WP_Locale

@realloc
9 years ago

Tests for WP_Locale - Corrected patch

@realloc
9 years ago

Fix: ( 'am' ) instead of _( 'am' )

#1 @johnbillion
9 years ago

  • Keywords has-patch has-unit-tests added
  • Version trunk deleted

#2 @johnbillion
9 years ago

  • Milestone changed from Awaiting Review to Future Release

@swissspidy
9 years ago

#3 @swissspidy
9 years ago

  • Milestone changed from Future Release to 4.5

34688.diff​ tests all public methods with possible values.

#4 @swissspidy
9 years ago

@ocean90 You got some experience with i18n/WP_Locale. Anything else you would test here?

#5 @johnbillion
9 years ago

  • Owner set to johnbillion
  • Resolution set to fixed
  • Status changed from new to closed

In 36292:

I18N: Introduce tests for WP_Locale.

Props realloc, swissspidy
Fixes #34688

Note: See TracTickets for help on using tickets.