WordPress.org

Make WordPress Core

Changes between Initial Version and Version 1 of Ticket #34691


Ignore:
Timestamp:
11/15/2015 11:03:30 PM (4 years ago)
Author:
johnbillion
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #34691

    • Property Keywords needs-patch needs-unit-tests added
    • Property Milestone changed from Awaiting Review to 4.4
  • Ticket #34691 – Description

    initial v1  
    2323It will return "meta_value" when sorting by a meta value, and thus the column will never be recognized when rendering the sortable header (unless its name is in fact meta_value).
    2424
    25 Before WP4.4, the check would be on $_GET["orderby"] that would return the actual sorting key, in this example "some_key".
     25Before WP4.4, the check would be on `$_GET["orderby"]` that would return the actual sorting key, in this example "some_key".
    2626
    27 I like the idea of the new abstraction of get_orderby(), but why was it changed from $_GET? Would anything break if we changed it back?
     27I like the idea of the new abstraction of get_orderby(), but why was it changed from `$_GET`? Would anything break if we changed it back?
    2828
    2929E.g.: