Changes between Initial Version and Version 1 of Ticket #34691
- Timestamp:
- 11/15/2015 11:03:30 PM (9 years ago)
Legend:
- Unmodified
- Added
- Removed
- Modified
-
Ticket #34691
- Property Keywords needs-patch needs-unit-tests added
-
Property
Milestone
changed from
Awaiting Review
to4.4
-
Ticket #34691 – Description
initial v1 23 23 It will return "meta_value" when sorting by a meta value, and thus the column will never be recognized when rendering the sortable header (unless its name is in fact meta_value). 24 24 25 Before WP4.4, the check would be on $_GET["orderby"]that would return the actual sorting key, in this example "some_key".25 Before WP4.4, the check would be on `$_GET["orderby"]` that would return the actual sorting key, in this example "some_key". 26 26 27 I like the idea of the new abstraction of get_orderby(), but why was it changed from $_GET? Would anything break if we changed it back?27 I like the idea of the new abstraction of get_orderby(), but why was it changed from `$_GET`? Would anything break if we changed it back? 28 28 29 29 E.g.: