Unknown system variable storage_engine when running tests in MySQL 5.7

[jeremyfelt]

The MySQL system variable storage_engine was ​removed in 5.7 after being deprecated in 5.5. The following error is shown when running our tests with MySQL 5.7:

PHPUnit_Framework_Exception: WordPress database error Unknown system variable 'storage_engine' for query SET storage_engine = INNODB

It looks like we should be able to convert our use to default_storage_engine when setting up WordPress for unit tests.

Related #30462

[pento]

default_storage_engine was ​added in MySQL 5.5.3, so this will fail on older MySQL versions.

[Collizo4sky]

Got this same error today. Note: am using Laravel Homestead with MySQL 5.7.9.

How do i solve this problem?

[skithund]

Got hit by this today. Revised patch checks MySQL version.

[pento]

In 36055:

Tests: Use the default_storage_engine MySQL option on newer MySQL versions.

In MySQL 5.5.3, storage_engine was deprecated in favour of default_storage_engine, and subsequently removed in MySQL 5.7. To avoid errors when running tests on MySQL 5.7, we need to switch between the options based on MySQL version.

Props skithund, jeremyfelt.

Fixes #34692.

[jorbin]

@pento If this is backported to 4.4.1, would that mean 4.4.1 would completely support MySQL 5.7?

[pento]

4.4 already supports MySQL 5.7, it's just that the tests don't run.

This is not a regression in 4.4, but it is a fairly small change, so I have no strong feelings either way about backporting it to 4.4.1.

[jorbin]

Cool beans.