WordPress.org
Get WordPress

Make WordPress Core

Opened 8 years ago

Closed 8 years ago

Last modified 8 years ago

#34704 closed defect (bug) (fixed)

Install: Use new colors for error notices

Reported by: ocean90's profile ocean90 Owned by: dbrumbaugh10up's profile DBrumbaugh10Up
Milestone: 4.5 Priority: normal
Severity: normal Version:
Component: Upgrade/Install Keywords: good-first-bug has-patch
Focuses: ui Cc:

Description

Looks like we missed to update the styles in wp-admin/css/install.css.

Attachments (6)

34704.before.png​ (54.8 KB) - added by ocean90 8 years ago.
NewMessageCSS.png​ (48.7 KB) - added by DBrumbaugh10Up 8 years ago.
The look after the update
install-message-css.patch​ (542 bytes) - added by DBrumbaugh10Up 8 years ago.
The patch file
34704-screenshots.png​ (47.2 KB) - added by duaneblake 8 years ago.
Screenshot of different browsers
new-colors-for-error-messages-34704.patch​ (431 bytes) - added by duaneblake 8 years ago.
Updated install css to match the notice styling
34704-screenshots-newstyle.png​ (36.1 KB) - added by duaneblake 8 years ago.
Browser testing

Download all attachments as: .zip

Change History (15)

@ocean90
8 years ago

#1 @DBrumbaugh10Up
8 years ago

As this is a "Good First Bug" I'd like to request that it be assigned to me.

#2 @DrewAPicture
8 years ago

  • Owner set to DBrumbaugh10Up
  • Status changed from new to assigned

@DBrumbaugh10Up typically we wait until somebody has uploaded a patch addressing the issue. Feel free to take the lead, however :)

#3 @DBrumbaugh10Up
8 years ago

Thank you @DrewAPicture !

@DBrumbaugh10Up
8 years ago

The look after the update

@DBrumbaugh10Up
8 years ago

The patch file

#4 @DBrumbaugh10Up
8 years ago

  • Keywords has-patch added; needs-patch removed

@duaneblake
8 years ago

Screenshot of different browsers

#5 @duaneblake
8 years ago

I've tested the patch in a few browsers and the error message now follow the format on the other pages. Screen shots above.

#6 @ocean90
8 years ago

  • Keywords needs-refresh added

This should use the alternate styling of notices, see #32244.

@duaneblake
8 years ago

Updated install css to match the notice styling

@duaneblake
8 years ago

Browser testing

#7 @duaneblake
8 years ago

I've changed the styling to match the notice styling which was set on #32244. See patch and testing results above.

#8 @ocean90
8 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 36178:

Install: Use new colors for error notices.

Props duaneblake, DBrumbaugh10Up.
Fixes #34704.

#9 @ocean90
8 years ago

  • Keywords needs-refresh removed
  • Milestone changed from Future Release to 4.5
Note: See TracTickets for help on using tickets.