WordPress.org

Make WordPress Core

Opened 4 years ago

Closed 3 years ago

#34735 closed defect (bug) (wontfix)

Merge similar translation strings in wp-admin/includes/media.php

Reported by: ramiy Owned by:
Milestone: Priority: normal
Severity: normal Version:
Component: I18N Keywords: has-screenshots has-patch
Focuses: Cc:

Description

Both string in the media.php file. With the same context - audio album title.

first string: "%1$s" by %2$s.

second string: %1$s by %2$s.

They can be merged.

Attachments (3)

34735.png (94.4 KB) - added by ramiy 4 years ago.
34735.patch (555 bytes) - added by ramiy 4 years ago.
34735code.png (25.5 KB) - added by ramiy 4 years ago.

Download all attachments as: .zip

Change History (11)

@ramiy
4 years ago

@ramiy
4 years ago

#1 @ramiy
4 years ago

  • Keywords has-screenshots has-patch added

#2 @ramiy
4 years ago

Lines 310 and 319.

@ramiy
4 years ago

This ticket was mentioned in Slack in #core by ramiy. View the logs.


4 years ago

#4 @SergeyBiryukov
4 years ago

  • Keywords close added

Looks like the intention was to put track title in quotes, but not the album title.

#5 @ramiy
3 years ago

@SergeyBiryukov, If that is the case we can close the ticket. Otherwise, we should add the quotes to the album title too. I personally think that both the track title and the album title should have quotes.

This ticket was mentioned in Slack in #core-i18n by ramiy. View the logs.


3 years ago

This ticket was mentioned in Slack in #core-i18n by ocean90. View the logs.


3 years ago

#8 @swissspidy
3 years ago

  • Keywords close removed
  • Milestone Awaiting Review deleted
  • Resolution set to wontfix
  • Status changed from new to closed

As discussed in today's bug scrub, putting track titles in quotes is very common in online media, at least some Google searches reveal that. It's not really done for album titles though, so I think it's safe to close this as a wontfix.

Note: See TracTickets for help on using tickets.