Opened 11 years ago
Closed 10 years ago
#34744 closed defect (bug) (fixed)
Don't use regex replacement to set force_default to true for images under Settings > Discussion > Default Avatar
| Reported by: | henry.wright | Owned by: | swissspidy |
|---|---|---|---|
| Priority: | normal | Milestone: | 4.6 |
| Component: | Administration | Version: | 4.2 |
| Severity: | normal | Keywords: | has-patch commit |
| Cc: | Focuses: |
Description
Now that get_avatar() accepts a 5th param, we should use it to set force_default instead of using preg_replace(). Patch to follow...
Attachments (2)
Change History (12)
#4
@
11 years ago
- Milestone Future Release → 4.5
- Owner set to
- Status new → reviewing
- Type enhancement → defect (bug)
- Version 4.3.1 → 4.2
#5
@
11 years ago
Note: The resulting HTML, which is being filtered in default_avatar_select, changes slightly using this patch. Instead of appending forcedefault=1 to the URL, it contains &f=y.
Not a big deal, but I'm not sure if it's big enough to skip for 4.5
#6
@
11 years ago
According to Grav, either f or forcedefault can be used as the param:
https://en.gravatar.com/site/implement/images/#force-default
Note:
See TracTickets
for help on using tickets.
![(please configure the [header_logo] section in trac.ini)](/chrome/site/your_project_logo.png)
I should mention this will help fix BuddyPress ticket 6298.
Ref: https://buddypress.trac.wordpress.org/ticket/6298.