#34755 closed defect (bug) (fixed)
"(Currently set to: %s)" string should use the location name instead of slug
Reported by: | SergeyBiryukov | Owned by: | westonruter |
---|---|---|---|
Milestone: | 4.5 | Priority: | normal |
Severity: | normal | Version: | 4.3 |
Component: | Customize | Keywords: | has-patch |
Focuses: | Cc: |
Attachments (3)
Change History (11)
#2
@
9 years ago
- Keywords needs-patch added; has-patch removed
- Milestone changed from Future Release to 4.5
- Owner set to ryankienstra
- Status changed from new to assigned
- Version set to 4.3
I'm noticing a build failure for the pull request, namely in the qunit tests: https://travis-ci.org/xwp/wordpress-develop/jobs/109268978#L1141
It looks like the test fixtures need to be updated to include the locationSlugMappedToName
.
I also leaved a minor comment on the PR: https://github.com/xwp/wordpress-develop/pull/141#discussion_r52860094
#3
@
9 years ago
Updated Patch With 2 Corrections
Issue Of Failing JUnit Test Remains
@westonruter,
Thanks for your comments on the pull request for this ticket. Please see the new patch, based on your feedback.
As you mentioned here, there is still a failing JUnit test. This is at tests/qunit/wp-admin/js/customize-nav-menus.js#L27. I'll work on this soon.
#4
@
9 years ago
New Patch That Fixes JUnit Test
@westonruter,
Please see this patch, which has passing JUnit tests. The pull request's Travis build now passes.
As you suggested, I fixed the failing JUnit test by adding the object locationSlugMappedToName
to fixtures/customize-menus.js.
#5
@
9 years ago
- Keywords has-patch added; needs-patch removed
- Owner changed from ryankienstra to westonruter
- Status changed from assigned to accepted
Thanks!
Patch For Defect
Requesting Review
@SergeyBiryukov,
Attached is a patch, and an identical GitHub PR for this defect.
This changes the "Menu Location" string in Customizer menu controls to the location name. Before, this string was the location slug.
So this adds an object to the data passed to the Customizer :
locationSlugMappedToName
. And uses this to retrieve the location name.This also changes the argument name from
themeLocations
tothemeLocationSlugs
. This doesn't change the argument, it only clarifies the fact that it consists of slugs.