WordPress.org
Get WordPress

Make WordPress Core

Changes between Initial Version and Version 1 of Ticket #34755, comment 3


Ignore:
Timestamp:
02/15/2016 06:12:56 AM (9 years ago)
Author:
ryankienstra
Comment:

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #34755, comment 3

    initial v1  
    33
    44@westonruter,
    5 Thanks for your [https://github.com/xwp/wordpress-develop/pull/141#discussion-diff-52860094 comments] on the [https://github.com/xwp/wordpress-develop/pull/141 pull request] for this ticket. Please see the new [https://github.com/xwp/wordpress-develop/pull/141 patch], based on your feedback.
     5Thanks for your [https://github.com/xwp/wordpress-develop/pull/141#discussion-diff-52860094 comments] on the [https://github.com/xwp/wordpress-develop/pull/141 pull request] for this ticket. Please see the new [https://core.trac.wordpress.org/attachment/ticket/34755/77813f8.diff patch], based on your feedback.
    66
    77As you [https://core.trac.wordpress.org/ticket/34755#trac-change-2-1455513221285388 mentioned] here, there is still a failing JUnit test. This is at [https://core.trac.wordpress.org/browser/trunk/tests/qunit/wp-admin/js/customize-nav-menus.js#L27 tests/qunit/wp-admin/js/customize-nav-menus.js#L27]. I'll work on this soon.